Fixed bug with implode parameter order #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `implode` here is deprecated as of PHP 7.4, and invalid as of PHP 8. This is breaking webmentions in Known installations on those platforms, and presumably other downstream clients.
pfefferle
approved these changes
Feb 2, 2021
Member
pfefferle
left a comment
pfefferle
left a comment
There was a problem hiding this comment.
oops, I think this was my false :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
implodehere with the separator after the array is deprecated as of PHP 7.4, and invalid as of PHP 8. This is breaking webmentions in Known installations on those platforms, and presumably other downstream clients.PHP reference: https://www.php.net/manual/en/function.implode.php