Do not download big resources when using curl #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firesphere
reviewed
Jan 25, 2026
| curl_setopt($ch, CURLOPT_HEADER, true); | ||
| curl_setopt($ch, CURLOPT_NOBODY, true); | ||
| curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true); | ||
| curl_setopt($ch, CURLOPT_MAXFILESIZE, self::$_maxFilesize); |
There was a problem hiding this comment.
I don't expect the headers to exceed the 1MB, but for consistency, not a bad thing to put it in anyway.
Member
Author
There was a problem hiding this comment.
I simply did not check if curl automatically cuts the connection after the last header, or if it continues to fetch data if a server decides to send a body on a HEAD request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully addresses the concerns of #45.
Note:
MentionClientignores curl errors and just silently carries on. There will not be a difference between a resource that does not advertise an endpoint or a resource that goes over the maximum file size.