Fix: prevent infinite loading on identical language translation #1499
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This update improves the translation plugin’s behavior when the selected source and target languages are the same. Changes
Reason Previously, initiating translation with identical languages caused the UI to enter a loading state without performing any action, leading to confusing UX and an endless spinner. This fix ensures proper validation, clearer feedback, and consistent UI state management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1488
This PR improves the translation plugin by implementing a validation check that prevents initiating a process when source and target languages are identical. Previously, this triggered an infinite loading spinner and a confusing UI state. This update replaces the indefinite loading state with a direct user-facing error and cleans up redundant UI warnings, ensuring more robust state management and a better UX.