Skip to content

added option to symlink (ln -s)#48

Merged
jfilter merged 2 commits into
jfilter:mainfrom
cs-mshah:main
Jan 27, 2026
Merged

added option to symlink (ln -s)#48
jfilter merged 2 commits into
jfilter:mainfrom
cs-mshah:main

Conversation

@cs-mshah

@cs-mshah cs-mshah commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

This solves #31. The advantage of having symlinks (ln -s) is that we can just reference the dataset stored at some other place and create a folder structure at any/multiple desired locations as required by some codebases. Deleting symlinks doesn't delete the original dataset.

The changes have been made to support backward compatibility of move=True and move=False along with the addition of move='symlink'. All tests have successfully passed.

@a1302z

a1302z commented Apr 5, 2023

Copy link
Copy Markdown

This works wonderfully. Instead of cloning the entire dataset now, I just have links to the original image, which saves so much time and memory. I am very much in favor of merging this into the package.

@catevita

catevita commented Dec 7, 2023

Copy link
Copy Markdown

hi, this option would be amazing, will it be integrated?

@jfilter jfilter merged commit 28efbaf into jfilter:main Jan 27, 2026
@jfilter

jfilter commented Jan 27, 2026

Copy link
Copy Markdown
Owner

Merged into main — thanks @cs-mshah! The symlink feature is now available via move='symlink'. I also refactored the duplicated copy/move/symlink logic into a shared helper and cleaned up the code with ruff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants