-
Notifications
You must be signed in to change notification settings - Fork 62
Useful SGR Code Propagation #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
been on this for hours, time to commit before i lose it, I have started to integrate with other projects successfully I think its ready for merge
CodSpeed Performance ReportMerging this PR will degrade performance by 33.83%Comparing Summary
Performance Changes
|
|
It is expected to be slower, however by "state tracking"
If this library is used to "build" text strings, those text strings now put less load on the terminal emulator, however it is certainly executed slower in python than in C, so it is a performance hit for correctness. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
===========================================
- Coverage 100.00% 98.36% -1.64%
===========================================
Files 13 14 +1
Lines 668 919 +251
Branches 164 234 +70
===========================================
+ Hits 668 904 +236
- Misses 0 6 +6
- Partials 0 9 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
From integration and study of downstream uses and needs, as documented in the primary new public API
function,
porpagate_sgr(), there is a need to track, set, and reset SGR attributes at theboundaries of returned lines when using
wrap()andclip():A related bug was discovered through extensive testing of "cafe" plus combining character,
that the combining characters were accidentally included outside of clip boundary, confused
with the zero-width nature of SGR codes