fix(i18n): correct mistranslated Japanese "Current Flow" label#13904
Open
greymoth-jp wants to merge 1 commit into
Open
fix(i18n): correct mistranslated Japanese "Current Flow" label#13904greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Japanese translation for ChangesJapanese Locale Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Japanese
version.currentFlowstring reads "電流の流れ" (the flow of electric current), but here "Current Flow" means the present flow version. It sits with the version-preview labels (version.previewing,version.readOnly,version.loadingPreview), so it labels the live flow as opposed to a historical version that is being previewed.The same
ja.jsonalready translates this correctly elsewhere:deployments.updateDeploymentDescriptionrenders "current flow version" as "現在のフローバージョン", and every other "Current" string uses 現在 (deployments.current,flowVersion.currentLabel,editNode.currentValue). This change bringsversion.currentFlowin line with those.en: "Current Flow"
before: 電流の流れ (electric current)
after: 現在のフロー
The same homograph is present in the other locale files (zh-Hans, de, fr, es, pt) if a follow-up is wanted.
Summary by CodeRabbit