Skip to content

Conversation

@ReviakinAleksey
Copy link
Contributor

@ReviakinAleksey ReviakinAleksey commented Apr 23, 2019

Mailing List thread: https://groups.google.com/forum/#!topic/liftweb/as0h7yPlyoY

Template rendered for crud.all Snippet in net.liftweb.proto.Crudify render empty td elements instead of TheCrudType filed values.
This PR introduce issue fix and test for this functional.

@Shadowfiend
Copy link
Member

@ReviakinAleksey sorry for taking so long to reply. This is a great PR! Love the new test 😍 Only issue I see is it looks like the test isn’t compiling in CI: https://travis-ci.org/lift/framework/jobs/523455236#L2271

@ReviakinAleksey
Copy link
Contributor Author

ReviakinAleksey commented May 20, 2019

@ReviakinAleksey sorry for taking so long to reply. This is a great PR! Love the new test 😍 Only issue I see is it looks like the test isn’t compiling in CI: https://travis-ci.org/lift/framework/jobs/523455236#L2271

Hello @Shadowfiend, unfortunately I only test my code inside IDEA IDE, and mess up PR in first lines.
Line number 5: import net.liftweb.http.{LiftRules, LiftSession, WithLiftContext} which produce object WithLiftContext is not a member of package net.liftweb.h compilation error in sbt test.
I use WithLiftContext to render Crudify snippet in most simplest way.

Could you please give me a help hand with this PR and suggest proper way to test snippet output?

@Shadowfiend
Copy link
Member

Ah, I see! WithLiftContext is part of testkit, which isn't a test dependency of the proto module's tests. This'll need some sbt fiddling… Not sure if I'll have time to do it but I'm going to try!

@ReviakinAleksey
Copy link
Contributor Author

I think I found proper solution, test now is using S.statelessInit(Req.nil) method instead of WithLiftContext trait.

@Shadowfiend
Copy link
Member

Nice! Awesome adjustment 😎 Let's rock and roll!

@Shadowfiend Shadowfiend merged commit 2fdb1ea into lift:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants