Fix confusing DontMergeAttributes modification #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| "leave node class attribute for replacement without class" in { | ||
| // TODO: Since was agreed not to change current behaviour, create test for it (https://groups.google.com/forum/#!topic/liftweb/Nswcxoykspc) |
Member
There was a problem hiding this comment.
Is this still a TODO or just an explanation of this test case?
farmdawgnation
approved these changes
Jul 13, 2019
Member
farmdawgnation
left a comment
farmdawgnation
left a comment
There was a problem hiding this comment.
This looks good. One outstanding question on a todo comment, but otherwise I'm happy.
Contributor
Author
|
Hi @farmdawgnation, this comment it only explaining why this weird test exists, and mention of fact that modification will not skip merging of class if replacement does not contains class attribute. Do you want me to change comment content? |
Member
|
Nope, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailing List thread:
Use DontMergeClass instead of confusing DontMergeAttributes modification.
Mark DontMergeAttributes as deprecated.
Added test for DontMergeClass and fixing docs for it css-selectors.adoc file.