Skip to content

feat(lift-common)!: scala 3 support #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
farmdawgnation merged 12 commits into from
Aug 20, 2025
Merged

feat(lift-common)!: scala 3 support #2031

farmdawgnation merged 12 commits into from
Aug 20, 2025
+63 −112

Conversation

@farmdawgnation
Copy link
Member

@farmdawgnation farmdawgnation commented Aug 11, 2025 •
edited
Loading

Implementation of a lift-common build that works in Scala 3.

  • Updated existential type with any
  • Explicitly invoke an ev implicit to get the compiler working
  • Fix indentation in LRU
  • Update dependencies
  • Change logFailure to public so that overrides work correctly
  • Fully replace scalatest-mock since it doesn't exist in Scala 3
  • Fix side effects of dependency upgrades throughout lift
@farmdawgnation
chore: prepare build for scala3
9b8befd
@farmdawgnation
fix(Box): Replace existental type with Any
14ec857 
This was really a helper to support some explicit casting. This *may*
result in a sight change in behavior, but as best I can tell it'll still
work.
@farmdawgnation
fix(Box): explicitly invoke ev implicit
dd20f09 
Changes to implicits mean we have to change how we do this. In favor of
leaving the API interface the same for now, I'm going to just driectly
invokce it.
@farmdawgnation
fix(LRU): fix indentation
63b25e9
@farmdawgnation farmdawgnation changed the base branch from main to lift-4.0 August 11, 2025 12:50
@farmdawgnation farmdawgnation marked this pull request as ready for review August 16, 2025 12:48
@farmdawgnation farmdawgnation requested a review from dpp August 16, 2025 12:48
dpp
dpp approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@dpp dpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
@farmdawgnation farmdawgnation merged commit 1f985f1 into lift-4.0 Aug 20, 2025
3 checks passed
@farmdawgnation farmdawgnation deleted the msf/lift-common-scala3 branch August 20, 2025 22:38
@github-project-automation github-project-automation bot moved this to In progress in Lift 4.0 Aug 21, 2025
@farmdawgnation farmdawgnation moved this from In progress to Done in Lift 4.0 Aug 21, 2025
@farmdawgnation farmdawgnation mentioned this pull request Aug 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@farmdawgnation @dpp