Skip to content

Conversation

@farmdawgnation
Copy link
Member

Support cross build for scala3 for lift-actor. Specifically:

  • Drop Java interop support
    • Some changes in the Scala 3 compiler seem to make it impossible to inherit SpecializedLiftActor via LiftActor in Java code.
  • Fixed a tailrec issue in Scala 3
Base automatically changed from msf/lift-common-scala3 to lift-4.0 August 20, 2025 22:38
@farmdawgnation farmdawgnation marked this pull request as ready for review August 21, 2025 01:54
@farmdawgnation farmdawgnation requested review from Copilot and dpp August 21, 2025 01:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Scala 3 support to the lift-actor module by removing Java interoperability features and fixing a tail recursion issue. The changes are part of a breaking change to enable cross-compilation with Scala 3.

  • Removes Java interop classes and annotations that are incompatible with Scala 3
  • Fixes tail recursion implementation in LAFuture.get method
  • Removes Java-based test files and related Scala test cases

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
web/webkit/src/main/scala/net/liftweb/http/CometActor.scala Removes Java interop classes LiftActorJWithListenerManager, CometActorJ, and CometActorJWithCometListener
core/actor/src/test/scala/net/liftweb/actor/ActorSpec.scala Removes Java actor test case
core/actor/src/test/java/net/liftweb/actor/MyJavaActor.java Deletes Java test actor implementation
core/actor/src/main/scala/net/liftweb/actor/LiftActor.scala Removes Java interop support including LiftActorJ class and reflection-based dispatch
core/actor/src/main/scala/net/liftweb/actor/LAFuture.scala Fixes tail recursion issue by restructuring the get method
core/actor/src/main/java/net/liftweb/actor/JavaActorBase.java Deletes Java annotation class for actor message handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-project-automation github-project-automation bot moved this to In progress in Lift 4.0 Aug 21, 2025
@farmdawgnation farmdawgnation merged commit 749a5cd into lift-4.0 Aug 23, 2025
3 checks passed
@farmdawgnation farmdawgnation deleted the msf/lift-actor-scala3 branch August 23, 2025 00:50
@github-project-automation github-project-automation bot moved this from In progress to Done in Lift 4.0 Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants