Open
Conversation
Its-Just-Nans
commented
Dec 14, 2025
| let mut pixmap = tiny_skia::PixmapMut::from_bytes(pixmap, width, height).unwrap(); | ||
|
|
||
| resvg::render(&tree.0, transform.to_tiny_skia(), &mut pixmap) | ||
| .expect("Failed to render to pixmap"); |
Contributor
Author
There was a problem hiding this comment.
Should we panic or fail quielty?
Its-Just-Nans
commented
Dec 14, 2025
| size.height() as f32 / tree.size().height() as f32, | ||
| ); | ||
| resvg::render(&tree, render_ts, &mut pixmap.as_mut()); | ||
| resvg::render(&tree, render_ts, &mut pixmap.as_mut()).expect("Failed to render"); |
Contributor
Author
There was a problem hiding this comment.
The best would be to resturn a Option<usize> or a Result<usize, String>
I don't really like to .expect() but I do it now for this MR for no breaking change
Contributor
Author
|
I understand that I made multiple MRs to improve safety but they contains breaking changes. Another solution would be to add more public method which are safer instead of editing the current ones (I can do that). Aka Instead of modifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #937
Fix #941
This change the API of render() but is still compatible I think
(returns None instead of crashing)
Maybe we could add #[must_use] ?