Add scale_by/scale_to functions to Size#146
Conversation
These match the implementations for for IntSize, making it simpler to implement floating point support in the resvg main binary.
jermy
force-pushed
the
add_size_scale_functions
branch
from
54790fb to
29b9e1d
Compare
|
The corresponding resvg change is resvg #875 |
|
@DJMcNab Thank you. Would it be reasonable to do a release of this at some point? (*) I can do a PR for a version bump, but have no idea what process is involved it getting it onto crates, and I suspect it might warrant going to 0.12.0 since it's been a while since the last release and there are quite a number of things that need adding to the changelog. (* A caveat would be whether my other mipmap PR #145 would want to be included as well) |
|
The place to ask this is probably on Zulip (i.e. creating a new thread in the resvg channel). Ultimately, tiny-skia doesn't really have a champion at the moment. |
|
I'm planning to get to a release of this once we get some other stuff released, hopefully this month. It would be good to get this crate a bit more aligned with Linebender stuff, but perhaps that won't happen for the first release under our banner. |
|
This has slipped; Tiny Skia and resvg are unfortunately quite far off the critical path for most people in Linebender, but it is our responsibility to allow the community to e.g. get releases out. @jermy I've started a Zulip thread (#resvg > Tiny Skia 0.12.0 (or 0.11.5)), which I'd encourage you to engage with there. I think if we want to get this released quickly, we can probably skip mipmapping. Ultimately, you're going to have to find someone who can review that - I don't know of any good candidates, unfortunately |
3 participants
These match the implementations for for IntSize, making it simpler to implement floating point support in the resvg main binary.
This is part of a fix for resvg #810.