Add frame processor support for audio streams #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianshijing-lk
approved these changes
Dec 2, 2025
theomonnom
reviewed
Dec 2, 2025
theomonnom
reviewed
Dec 2, 2025
davidzhao
approved these changes
Dec 2, 2025
| owned_buffer_info = audio_event.frame_received.frame | ||
| frame = AudioFrame._from_owned_info(owned_buffer_info) | ||
| if self._processor is not None: | ||
| frame = self._processor._process(frame) |
theomonnom
approved these changes
Dec 4, 2025
| def _process(self, frame: T) -> T: ... | ||
|
|
||
| @abstractmethod | ||
| def _close(self): ... |
Member
There was a problem hiding this comment.
I think it's OK for close to be public
Suggested change
| def _close(self): ... | |
| def close(self): ... |
Contributor
Author
There was a problem hiding this comment.
I was thinking close would rather be an internal method that we call to end the lifecycle of a processor.
Users would be expected to disable it with processor.enabled = False.
theomonnom
reviewed
Dec 4, 2025
Co-authored-by: Théo Monnom <theo.8bits@gmail.com>
…thon-sdks into lukas/frame-processor
…thon-sdks into lukas/frame-processor
lukasIO
commented
Dec 11, 2025
| manylinux-pypy_aarch64-image = "manylinux_2_28" | ||
|
|
||
| [tool.cibuildwheel.linux] | ||
| before-build = "pip install requests && python rust-sdks/download_ffi.py --output livekit/rtc/resources && yum install -y libX11-devel libXrandr-devel libXext-devel libXfixes-devel libXdamage-devel libXcomposite-devel libXi-devel mesa-libGL-devel || apt install -y xorg-dev" No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
@theomonnom calling this out explicitly for you to take a look.
After updating FFI we need these deps for the desktop capturer and the wheels repair command was failing with out them.
Member
There was a problem hiding this comment.
I think it's fine, but we should make sure the SDK is still working without users having to install those deps in their prod environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.