FreeBSD uses stat instead of stat64#1952
Merged
lovell merged 2 commits intolovell:masterfrom Nov 6, 2019
Merged
Conversation
lovell
reviewed
Nov 6, 2019
Owner
lovell
left a comment
lovell
left a comment
There was a problem hiding this comment.
Thank you, I've been meaning to add FreeBSD to the CI matrix to catch this kind of thing. One small question inline otherwise this is good to merge.
Owner
|
Brilliant, thank you, I'll add FreeBSD to the CI matrix to help prevent this occurring again. |
Contributor
Author
|
@lovell it may need extra steps to build on FreeBSD. Latest vips in FreeBSD ports is 8.7.4. I had to fork the port and update it to 8.8.3 to make sharp work. |
Owner
|
@pouya-eghbali Thanks, are you able to submit a PR/patch to ports itself to upgrade it to the latest vips? /cc @daniloegea in case this is already happening |
Owner
|
@pouya-eghbali I've created #1953 to track the addition of CI for FreeBSD. |
Contributor
Author
|
I sent an email to @daniloegea . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stat64does not exist on FreeBSD.