fix: Animated GIF to WEBP using a Sharp stream is not animated anymore#2369
Merged
lovell merged 1 commit intolovell:masterfrom Sep 15, 2020
Merged
fix: Animated GIF to WEBP using a Sharp stream is not animated anymore#2369lovell merged 1 commit intolovell:masterfrom
lovell merged 1 commit intolovell:masterfrom
Conversation
lovell
requested changes
Sep 15, 2020
Owner
lovell
left a comment
lovell
left a comment
There was a problem hiding this comment.
Thank you very much for this PR. There's one small comment about the tests that will need addressing but otherwise this is good to merge.
| }); | ||
| }); | ||
|
|
||
| it('should work with streams when only animated is set', function (done) { |
Owner
There was a problem hiding this comment.
Not all test environments will have *magick available - please can you wrap these two GIF output tests with:
if (sharp.format.magick.output.buffer) { ... }
fix: Skip the gif tests that requires magick if it's not possible.
AcrylicShrimp
force-pushed
the
fix-animated-options
branch
from
5efc3c1 to
f1521c5
Compare
Contributor
Author
|
Thank you for feedback! I applied what you said, could you review it's ok for now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2362.