Skip to content

binding.gyp: Fix warnings during compiling#244

Merged
lovell merged 1 commit intolovell:masterfrom
TheThing:patch-1
Jul 26, 2015
Merged

binding.gyp: Fix warnings during compiling#244
lovell merged 1 commit intolovell:masterfrom
TheThing:patch-1

Conversation

@TheThing
Copy link
Copy Markdown
Contributor

Fixes the following warnings while compiling:

D:\Forritun\Microsoft Visual Studio 14.0\VC\include\xlocale(341): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc (compiling source file ..\src\common.cc) [D:\sharp\build\sharp.vcxproj]
D:\Forritun\Microsoft Visual Studio 14.0\VC\include\xlocale(341): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc (compiling source file ..\src\operations.cc) [D:\sharp\build\sharp.vcxproj]
...etc...

Solution taken from here: nodejs/node-gyp#26 (comment)

Fixes the following warnings while compiling:

```
D:\Forritun\Microsoft Visual Studio 14.0\VC\include\xlocale(341): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc (compiling source file ..\src\common.cc) [D:\sharp\build\sharp.vcxproj]
D:\Forritun\Microsoft Visual Studio 14.0\VC\include\xlocale(341): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc (compiling source file ..\src\operations.cc) [D:\sharp\build\sharp.vcxproj]
...etc...
```

Solution taken from here: nodejs/node-gyp#26 (comment)
@lovell
Copy link
Copy Markdown
Owner

lovell commented Jul 26, 2015

Great, thank you. It looks like the existing msvs_settings directive is only picked up for Debug builds.

lovell added a commit that referenced this pull request Jul 26, 2015
Silence MSVC warning:
"C4530: C++ exception handler used,
but unwind semantics are not enabled."
@lovell lovell merged commit dee9ca3 into lovell:master Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants