crop: Permit specifying the gravity as a string#255
Merged
lovell merged 1 commit intolovell:masterfrom Aug 19, 2015
Merged
Conversation
Will be looked up in require('sharp').gravity.
lovell
added a commit
that referenced
this pull request
Aug 19, 2015
crop: Permit specifying the gravity as a string
Owner
|
Great, thank you Andreas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where the gravity is taken from a query string and it's cumbersome to use the numeric values or do a lookup in
require('sharp').gravity. Seemed like it would be easy (and desirable) to support the strings directly.Will conflict slightly with #205, but it should be easy to resolve.