Skip to content

Feat: Add support for JP2#2868

Closed
Zaruike wants to merge 6 commits intolovell:masterfrom
Zaruike:master
Closed

Feat: Add support for JP2#2868
Zaruike wants to merge 6 commits intolovell:masterfrom
Zaruike:master

Conversation

@Zaruike
Copy link
Copy Markdown
Contributor

@Zaruike Zaruike commented Aug 28, 2021

Requires libvips 8.11.0

This add the support for made JP2 file and JP2 buffer.

More info:
#2245

Code Example:

await sharp(image)
      .jp2({quality: 90})
      .toBuffer()
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 31, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c32b47e on Zaruike:master into e044788 on lovell:master.
lovell
lovell requested changes Aug 31, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this, I've left a few questions/comments inline that we should consider then this is ready to merge.
@Zaruike Zaruike requested a review from lovell September 1, 2021 17:36
lovell added a commit that referenced this pull request Sep 5, 2021
@lovell
Docs: add changelog entry for #2868
afb2113
@lovell lovell added this to the v0.29.1 milestone Sep 5, 2021
@lovell
Copy link
Copy Markdown
Owner

lovell commented Sep 5, 2021

Landed via commit b7fbffb - merci beaucoup!
@lovell lovell closed this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Zaruike @coveralls @lovell