Resolve paths before comparing input/output destination#2878
Merged
lovell merged 1 commit intolovell:masterfrom Sep 6, 2021
rexxars:fix/improve-input-output-filename-matching
Merged
Resolve paths before comparing input/output destination#2878lovell merged 1 commit intolovell:masterfrom rexxars:fix/improve-input-output-filename-matching
lovell merged 1 commit intolovell:masterfrom
rexxars:fix/improve-input-output-filename-matching
Conversation
This fixes an issue where if you try to write to the same destination as the input file but you are not using absolute (or the same relative path) for both the input and output, sharp/vips might produce errors such as: ``` someFile.jpg: unable to open for write unix error: No such file or directory ``` Fixes #2873
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if you try to write to the same destination as the input file but you are not using absolute (or the same relative path) for both the input and output, sharp/vips might produce errors such as:
Fixes #2873