fix: allow boolean withMetadata argument#3823
Merged
lovell merged 1 commit intolovell:gaugefrom Oct 11, 2023
Merged
Conversation
lovell
requested changes
Oct 11, 2023
Owner
lovell
left a comment
lovell
left a comment
There was a problem hiding this comment.
Thank you very much for reporting and fixing this. Please can you add a test to help avoid regression.
Contributor
Author
|
@lovell Done. |
Owner
|
Thank you, I'm not planning any v0.32.x patch releases so I've merged this for inclusion in v0.33.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3822