fix(types): update Channels type#4197
Closed
DavidVaness wants to merge 1 commit intolovell:mainfrom
DavidVaness:fix/channels-type
Closed
fix(types): update Channels type#4197DavidVaness wants to merge 1 commit intolovell:mainfrom DavidVaness:fix/channels-type
DavidVaness wants to merge 1 commit intolovell:mainfrom
DavidVaness:fix/channels-type
Conversation
This PR adds 1 and 2 as possible values 1: The image has only one channel representing grayscale values. Each pixel is stored as a single intensity value, ranging from black to white. 2: The image could have one channel for grayscale intensity and another channel for alpha (transparency). This is similar to an RGBA image but without the color information, only grayscale (intensity) and alpha. Possibly there are other reasons for a 2 channel Image but this is the most common one in my experience
Owner
|
Thanks for the PR. It looks like Lines 985 to 986 in fc32e0b Perhaps we could split this into something like |
lovell
pushed a commit
that referenced
this pull request
Oct 13, 2024
Owner
|
Landed via commit 1533bf9, thank you for fixing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @lovell, improving on the types again
This PR adds 1 and 2 as possible values for the Channels type:
1: The image has only one channel representing grayscale values. Each pixel is stored as a single intensity value, ranging from black to white.
2: The image could have one channel for grayscale intensity and another channel for alpha (transparency). This is similar to an RGBA image but without the color information, only grayscale (intensity) and alpha.
Possibly there are other reasons for a 2 channel Image but this is the most common one in my experience