Conversation
lovell
left a comment
lovell
left a comment
There was a problem hiding this comment.
Thanks for the PR. There are a couple of lines that will need updating to get everything working.
binding.js
Outdated
| const gotOpt = { | ||
| const url = distBaseUrl + tarFilename; | ||
| const simpleGetOpt = { | ||
| url, |
There was a problem hiding this comment.
This will probably need to be url: url, as Node v4 lacks destructuring support.
binding.js
Outdated
| }; | ||
| const url = distBaseUrl + tarFilename; | ||
| got.stream(url, gotOpt).on('response', function (response) { | ||
| simpleGet.stream(simpleGetOpt, function (err, response) { |
There was a problem hiding this comment.
Is this correct? Perhaps simpleGet(simpleGetOpt, ...?
There was a problem hiding this comment.
Oops, yeah. You're right. Fixing.
pbomb
force-pushed
the
got-to-simple-get
branch
from
c614988 to
b71a342
Compare
|
Brilliant, thank you! |
|
The v0.19.0 milestone still has 9 open issues, but I'd really like to get this change released to unblock my work. Any chance of making a patch release with just this change? It should be transparent to users. |
No worries. Your profile suggests "work" in this context might relate to "Workday, Inc". If so, do you think your employer might be able to make a suitable donation to a local homelessness charity by way of thanks? |
|
Sure. I just made a donation which they'll match. Thanks! |
3 participants
Fixes #938