Skip to content

Handle leading comments in queries#164

Merged
macbre merged 7 commits into
masterfrom
handle-leading-comments
Jun 10, 2021
Merged

Handle leading comments in queries#164
macbre merged 7 commits into
masterfrom
handle-leading-comments

Conversation

@macbre

@macbre macbre commented Jun 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Owner

Fixes #163

Example case

    assert ["bar"] == Parser("/* foo */ INSERT IGNORE INTO bar VALUES (1, '123', '2017-01-01');").tables
@macbre macbre added the bug label Jun 10, 2021
@macbre macbre added this to the v2.3 milestone Jun 10, 2021
@macbre macbre requested a review from collerek June 10, 2021 13:57
@macbre macbre marked this pull request as ready for review June 10, 2021 13:57
@macbre macbre removed this from the v2.3 milestone Jun 10, 2021
@macbre macbre mentioned this pull request Jun 10, 2021
Closed
collerek
collerek reviewed Jun 10, 2021
View reviewed changes
Comment thread test/test_getting_tables.py Outdated
@macbre macbre requested a review from collerek June 10, 2021 15:18
@macbre macbre added this to the v2.2.1 milestone Jun 10, 2021
@macbre macbre merged commit bbe8d25 into master Jun 10, 2021
@macbre macbre deleted the handle-leading-comments branch June 10, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug

2 participants

@macbre @collerek