Skip to content

Conversation

@szhorvat
Copy link
Contributor

@szhorvat szhorvat commented Nov 29, 2025

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 26.1 25B78 arm64
Xcode 26.1.1 17B100

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?
@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port ninja.

@szhorvat
Copy link
Contributor Author

@barracuda156 Please double-check that the legacysupport line was indeed okay to remove.

@barracuda156
Copy link
Contributor

I had a patch instead of the PG, but dropping it breaks the build:

./src/jobserver-posix.cc: In member function 'bool {anonymous}::PosixJobserverClient::InitWithFifo(const std::string&, std::string*)':
./src/jobserver-posix.cc:86:66: error: 'O_CLOEXEC' was not declared in this scope; did you mean 'FD_CLOEXEC'?
   86 |     read_fd_ = ::open(fifo_path.c_str(), O_RDONLY | O_NONBLOCK | O_CLOEXEC);
      |                                                                  ^~~~~~~~~
      |                                                                  FD_CLOEXEC
bootstrapping ninja...
"./src/inline.sh" kBrowsePy < ./src/browse.py > build/browse_py.h

So no, it will not work without either PG or a patch.

@szhorvat
Copy link
Contributor Author

@barracuda156 I thought this was fixed upstream. Aren't the two commits linked at the very end of ninja-build/ninja#2645 means to fix this? What am I misunderstanding?

@barracuda156
Copy link
Contributor

@szhorvat Apparently that patch did not land into 1.13.2 / in upstream.

@digit-google Could you please advise which version of your patch should be used? Looks there are more than one now.

@szhorvat
Copy link
Contributor Author

Re-added the legacysupport line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer: open Affects an openmaintainer port type: update

4 participants