Skip to content

Conversation

@gakshita
Copy link
Collaborator

@gakshita gakshita commented Jan 9, 2026

Description

  • added bundler script for types
  • exported OAuthClient

Summary by CodeRabbit

  • New Features

    • OAuthClient is now publicly exported and available for import.
  • Chores

    • Bumped version to 0.2.6.
    • Improved build process to automatically bundle TypeScript declarations.
    • Added development tooling dependency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

📝 Walkthrough

Walkthrough

Version bumped to 0.2.6 with a new TypeScript declaration bundling build step integrated via dts-bundle-generator. The OAuthClient class is now publicly exported from the main entry point.

Changes

Cohort / File(s) Summary
Build Configuration
package.json
Version updated to 0.2.6; build script now runs tsc && pnpm run build:types-bundle; new build:types-bundle script added to generate bundled type definitions; dts-bundle-generator ^9.5.1 added as devDependency
Public Exports
src/index.ts
OAuthClient exported from ./client/oauth-client module

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hops of joy for types so neat!
A bundle born, the build's complete,
New exports hop into the light,
Version bumped—the future's bright!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: adding a bundler script for types and exporting OAuthClient.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prashant-Surya Prashant-Surya merged commit 94a13d9 into main Jan 9, 2026
1 of 2 checks passed
@Prashant-Surya Prashant-Surya deleted the fix-types branch January 9, 2026 13:02
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

17-17: Consider removing --no-check flag and verify the types field configuration.

The --no-check flag skips type checking during bundle generation, which could hide type errors in the bundled declarations. Additionally, the types field (line 11) still points to dist/index.d.ts rather than the newly generated dist/types.bundle.d.ts.

Clarify whether:

  1. The bundle file is intended to be the main types entry point (if so, update line 11 to "types": "dist/types.bundle.d.ts")
  2. The --no-check flag is necessary (consider removing it to catch type errors during build)
♻️ Proposed refinement

If the bundle should be the main types entry:

-  "types": "dist/index.d.ts",
+  "types": "dist/types.bundle.d.ts",

And consider enabling type checking:

-    "build:types-bundle": "dts-bundle-generator --no-check -o dist/types.bundle.d.ts dist/index.d.ts",
+    "build:types-bundle": "dts-bundle-generator -o dist/types.bundle.d.ts dist/index.d.ts",
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1d3531 and 2d22ad3.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • src/index.ts
🔇 Additional comments (4)
package.json (3)

3-3: LGTM!

The version bump from 0.2.5 to 0.2.6 is appropriate for a patch release that adds new functionality and build tooling.


18-18: LGTM!

The build script correctly chains TypeScript compilation followed by type bundling using && for sequential execution.


50-50: No action required—dts-bundle-generator version ^9.5.1 is current.

Version 9.5.1 is the latest available on npm (released April 2024), and no known security vulnerabilities were detected.

src/index.ts (1)

4-6: OAuthClient module is properly implemented and correctly exported.

The src/client/oauth-client.ts file exists with the OAuthClient class properly defined and exported. The export statement in src/index.ts correctly references the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants