Skip to content

[WEB-515] fix: spreadsheet layout overflow #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sriramveeraghanta merged 3 commits into from
Feb 22, 2024
Merged

[WEB-515] fix: spreadsheet layout overflow #3758

sriramveeraghanta merged 3 commits into from
Feb 22, 2024

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 22, 2024 •
edited
Loading

Problem:

  1. Properties dropdown in all layouts overflow the header.
  2. Spreadsheet column sort by dropdown overlaps with the app header.
  3. Spreadsheet title column header does not stick to the top.

Solution:

  1. Resolved a z-indexing problem causing the overflow and conducted testing to ensure resolution wherever applicable.
  2. Implemented necessary modifications to the spreadsheet layout to resolve the dropdown overlap with the app header.
  3. Implemented necessary changes to the spreadsheet header component to address the issue of the title column header not sticking to the top.

Issue link: [WEB-515]
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 22, 2024
View reviewed changes
web/components/headers/cycle-issues.tsx
</span>
<Link href={`/${workspaceSlug}/projects/${currentProjectDetails?.id}/issues`} className="block md:hidden pl-2 text-custom-text-300">...</Link>
<Link
href={`/${workspaceSlug}/projects/${currentProjectDetails?.id}/issues`}

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection depends on a [user-provided value](1).
web/components/headers/module-issues.tsx
</span>
<Link href={`/${workspaceSlug}/projects/${currentProjectDetails?.id}/issues`} className="block md:hidden pl-2 text-custom-text-300">...</Link>
<Link
href={`/${workspaceSlug}/projects/${currentProjectDetails?.id}/issues`}

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection depends on a [user-provided value](1).
@anmolsinghbhatia anmolsinghbhatia added this to the v0.16 milestone Feb 22, 2024
@anmolsinghbhatia anmolsinghbhatia linked an issue Feb 22, 2024 that may be closed by this pull request
[bug]: State filter dropdown on Issues spreadsheet layout is broken #3757
Closed
1 task
@anmolsinghbhatia anmolsinghbhatia changed the title [WEB-514] [WEB-515] fix: spreadsheet layout overflow Feb 22, 2024
@sriramveeraghanta sriramveeraghanta merged commit ebad7f0 into develop Feb 22, 2024
@sriramveeraghanta sriramveeraghanta deleted the fix/spreadsheet-layout-overflow branch February 22, 2024 14:50
vamsikrishnamathala pushed a commit that referenced this pull request Aug 7, 2025
@aaryan610
[WIKI-537] [WIKI-539] refactor: document editor (#3758)
dd4e733 
* refactor: document editor

* chore: update user prop

* fix: type warning

* refactor: document read only editor

* chore: update value prop name

* chore: remove unnecessary exports

* hore: update initialValue type

* chore: revert initialValue type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🧹chore 🌐frontend 🌟improvement

3 participants

@anmolsinghbhatia @sriramveeraghanta