Skip to content

[WEB-655] chore: peek overview dropdowns keyboard navigation improvement #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sriramveeraghanta merged 4 commits into from
Mar 6, 2024
Merged

[WEB-655] chore: peek overview dropdowns keyboard navigation improvement #3888

sriramveeraghanta merged 4 commits into from
Mar 6, 2024

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Mar 6, 2024

Problem:

  1. In the Peek overview, when navigating within the issue description slash command, pressing "esc" closes the Peek overview modal unexpectedly, which is not the intended behavior. The same issue occurs with the properties dropdown.

Solution:

  1. This issue has been resolved by adding required validation to ensure that it functions as expected.

Issue link: [WEB-655]

Media:

Before After
ccd07928-9256-47e7-9690-40e64a7014ac ff4e02a7-88e2-4ed1-ad1d-8bcb79edfc91
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review March 6, 2024 12:29
@anmolsinghbhatia anmolsinghbhatia added this to the v0.17.0-dev milestone Mar 6, 2024
@anmolsinghbhatia
Merge branch 'develop' of github.com:makeplane/plane into chore/peek-…
3f030ed 
…overview-dropdowns-keyboard-navigation-improvement
@sriramveeraghanta sriramveeraghanta merged commit 66f2492 into develop Mar 6, 2024
@sriramveeraghanta sriramveeraghanta deleted the chore/peek-overview-dropdowns-keyboard-navigation-improvement branch March 6, 2024 13:47
JayashTripathy pushed a commit that referenced this pull request Aug 24, 2025
@pablohashescobar
[WEB-4667] chore: outbox event payload and change the way transaction…
ccf24a6 
… variable is set (#3888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧹chore 🌐frontend 🌟improvement

4 participants

@anmolsinghbhatia @sriramveeraghanta @aaryan610