-
Notifications
You must be signed in to change notification settings - Fork 3.5k
chore: comment out APP_RELEASE variable update in build-branch workflow #6989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA single change was made to the GitHub Actions workflow file Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build-branch.yml (1)
276-276: Clarify intentional disabling of APP_RELEASE updateThe
sedcommand for updatingAPP_RELEASEindeploy/selfhost/variables.envhas been commented out, meaning the release version will no longer be injected into that file during the workflow. Please confirm this is the intended behavior and ensure that theAPP_RELEASEvalue is being set through an alternative mechanism or documented so future maintainers understand why this update was disabled.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-branch.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
Type of Change
Summary by CodeRabbit