Linter: Implement erb-no-extra-newline linter rule
#557
+535
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domingo2000
force-pushed
the
add-erb-extra-new-line
branch
from
e303205 to
d0230ca
Compare
Contributor
Author
|
I have the same thoughts of this rule as with SpaceInHtmlTag. This rules are "formatting rules", if the Herb formatter could (or can i don't know) verify that a file is correctly formatter, this rule should not be necessary and can be removed from the roadmap for ErbLint compatibility. I left an implementation anyways if you belive it provide some value. Feel free to change the severity from error to warning, or to make this rule an optional rule instead of default. |
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
Implements the `ExtraNewLine` rule from [ERBLint](https://github.com/Shopify/erb_lint). This rules avoid having multiple extra consecutives new lines in one file. Resolves marcoroth#541 --------- Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
ExtraNewLinerule from ERBLint.This rules avoid having multiple extra consecutives new lines in one file.
Resolves #541