Linter: Implement html-no-space-in-html-tag linter rule
#559
+444
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domingo2000
force-pushed
the
add-html-no-space-in-html-tag
branch
3 times, most recently
from
25e3965 to
2c0fcc4
Compare
domingo2000
commented
Oct 1, 2025
marcoroth
changed the title
domingo2000
force-pushed
the
add-html-no-space-in-html-tag
branch
2 times, most recently
from
ac6471a to
ea3881e
Compare
domingo2000
force-pushed
the
add-html-no-space-in-html-tag
branch
from
ea3881e to
4f96667
Compare
marcoroth
approved these changes
Oct 10, 2025
Owner
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
Thank you for working on this @domingo2000! 🙏🏼
marcoroth
added a commit
that referenced
this pull request
Oct 20, 2025
The `html-no-space-in-tag` linter rule (#559 and #642) has quite a few false positives and corrupts documents when using the `--fix` option (see #695), which is why this pull request removes the `html-no-space-in-tag` rule from the default rules for now. We can enable this rule again in the future when we improve the accuracy of the rule.
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
) Implements the `SpaceInHtmlTag` rule from [ERBLint](https://github.com/Shopify/erb_lint). This rules avoid having whitespace in the html. This is a Proof of concept of the implementation. I considered 1. If the parser already throws a parser error, the linter from erb-lint makes no sense (ej: `</ div>`) 2. It follows the result that the formatter would give. For example, for multiline, the whitespace must have 2 spaces. Resolves marcoroth#549 --------- Co-authored-by: Marco Roth <marco.roth@intergga.ch>
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
…coroth#697) The `html-no-space-in-tag` linter rule (marcoroth#559 and marcoroth#642) has quite a few false positives and corrupts documents when using the `--fix` option (see marcoroth#695), which is why this pull request removes the `html-no-space-in-tag` rule from the default rules for now. We can enable this rule again in the future when we improve the accuracy of the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
SpaceInHtmlTagrule from ERBLint.This rules avoid having whitespace in the html.
This is a Proof of concept of the implementation. I considered
</ div>)Resolves #549