Linter: Don't lint files with parser errors #614
Merged
+137
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
deleted the
linter-dont-lint-on-syntax-and-disallow-invalid-syntax-in-tests
branch
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
This pull request updates the linter to not lint files with syntax errors. This is to avoid false positives that might occur when trying to lint a file that isn't properly parsed, which could also lead to a "parser error" and "lint offense" diagnostic in the LSP. Additionally, it updates the Linter test helpers to make sure all test cases have valid syntax too. Since we have the `no-parser-errors` rule we will still catch syntax errors, invalid syntax, and parser errors with that rule in real applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the linter to not lint files with syntax errors. This is to avoid false positives that might occur when trying to lint a file that isn't properly parsed, which could also lead to a "parser error" and "lint offense" diagnostic in the LSP.
Additionally, it updates the Linter test helpers to make sure all test cases have valid syntax too. Since we have the
no-parser-errorsrule we will still catch syntax errors, invalid syntax, and parser errors with that rule in real applications.