Update all HTML+ERB globs to include Action View Variants #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcoroth Thank you!! |
|
@marcoroth Thank you so much! I really appreciate it. |
This was referenced Oct 15, 2025
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
) As discovered in kaigionrails/conference-app#601, we didn't include templates that had an Action View Variant in the filename (like `index.html+mobile.erb`). This pull request now updates all file globs Herb uses to also detect all Action View Variants. Thanks to @nissyi-gh and @unasuke for the help! 🙏🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in kaigionrails/conference-app#601, we didn't include templates that had an Action View Variant in the filename (like
index.html+mobile.erb).This pull request now updates all file globs Herb uses to also detect all Action View Variants.
Thanks to @nissyi-gh and @unasuke for the help! 🙏🏼