Skip to content

Engine: Add more tests for left and right ERB Trimming #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoroth merged 2 commits into from
Dec 3, 2025
Merged

Engine: Add more tests for left and right ERB Trimming #650

marcoroth merged 2 commits into from
Dec 3, 2025
+75 −9

Conversation

@marcoroth
Copy link
Owner

@marcoroth marcoroth commented Oct 15, 2025 •
edited
Loading

More tests for #649 and #841.
@marcoroth marcoroth added feature New feature or request engine labels Oct 15, 2025
@marcoroth marcoroth mentioned this pull request Nov 11, 2025
Merged
marcoroth added a commit that referenced this pull request Nov 11, 2025
@marcoroth
Engine: Add Support for ERB trimming (#841)
a06c5e9 
This pull request implements support for left trimming ` <%-` and right
trimming `-%>` in the `Herb::Engine`. This should now more closely match
the compiled template `Erubi::Engine` produces and renders.

Resolves #649
Enables #650
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 3, 2025 

npx https://pkg.pr.new/@herb-tools/formatter@650

npx https://pkg.pr.new/@herb-tools/language-server@650

npx https://pkg.pr.new/@herb-tools/linter@650

commit: 350c4ca
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:

🌱 Grown from commit 350c4ca

✅ Preview deployment has been cleaned up.
@marcoroth marcoroth changed the title Engine: Support left and right ERB Trimming Dec 3, 2025
@marcoroth marcoroth marked this pull request as ready for review December 3, 2025 18:12
@marcoroth marcoroth merged commit 1429d15 into main Dec 3, 2025
20 checks passed
@marcoroth marcoroth deleted the engine-trim-support branch December 3, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine feature New feature or request

2 participants

@marcoroth