Skip to content

Linter: Allow multiple rules to be ignored using <%# herb:disable %> #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoroth merged 5 commits into from
Oct 24, 2025
Merged

Linter: Allow multiple rules to be ignored using <%# herb:disable %> #680

marcoroth merged 5 commits into from
Oct 24, 2025

Conversation

@domingo2000
Copy link
Contributor

@domingo2000 domingo2000 commented Oct 18, 2025 •
edited by marcoroth
Loading

Now multiple rules can be ignored with the following syntax

  1. <%# herb:disable rule-1, rule-2 %>
  2. <%# herb:disable all %> will disable all rules in that line.

This follows the same convention proposed by standardrb

Resolves #665
@domingo2000
Linter: Ignore multiple rules with comments (marcoroth#665)
0421646 
Now rules can be ignored with <% herb:disable rule-1, rule-2 %> syntax
also support for disable all rules with <% herb:disable all %>:
@domingo2000
Copy link
Contributor Author

domingo2000 commented Oct 18, 2025

@marcoroth Documentation for this feature is still pending, but I believe it’s best if you write it wherever you find most appropriate.
@marcoroth marcoroth added feature New feature or request linter labels Oct 18, 2025
@marcoroth marcoroth changed the title Linter: Ignore multiple rules with comments (#665) Oct 18, 2025
@marcoroth marcoroth changed the title Linter: Ignore multiple rules with comments Oct 24, 2025
@marcoroth marcoroth merged commit 14d8ac6 into marcoroth:main Oct 24, 2025
2 checks passed
@marcoroth marcoroth mentioned this pull request Oct 24, 2025
Merged
marcoroth added a commit that referenced this pull request Oct 25, 2025
@marcoroth
Linter: Introduce herb-disable-comment-* family of linter rules (#735)
b74033f 
This pull request introduces the `herb-disable-comment-*` family of
linter rules. Rules to make sure that people are using the `<%#
herb:disable %>` comments (introduced in
#531 and #680) in a proper way.

The rules are also helpful to warn people early if they are using the
`<%# herb:disable %>` in an unexpected or invalid way, directly in their
editor without having to run the linter again to know if their
`herb:disable` worked.

**Examples**:

<img width="2428" height="282" alt="CleanShot 2025-10-25 at 00 38 38@2x"
src="https://github.com/user-attachments/assets/f726fc75-9c95-49d7-863a-aab98c735985"
/>

<img width="2342" height="352" alt="CleanShot 2025-10-25 at 00 38 48@2x"
src="https://github.com/user-attachments/assets/120ca109-9f9a-49fd-8a4e-2ba4156c2a78"
/>

<img width="2328" height="442" alt="CleanShot 2025-10-25 at 00 38 55@2x"
src="https://github.com/user-attachments/assets/37b50b7f-9f65-4731-b3c8-10bbe2a406c3"
/>

<img width="2238" height="276" alt="CleanShot 2025-10-25 at 00 39 03@2x"
src="https://github.com/user-attachments/assets/71d83541-813c-43a5-9670-854cd332445a"
/>

<img width="2176" height="276" alt="CleanShot 2025-10-25 at 00 39 11@2x"
src="https://github.com/user-attachments/assets/72020a44-656e-48f5-8718-7c6362c72479"
/>

<img width="2200" height="262" alt="CleanShot 2025-10-25 at 00 39 15@2x"
src="https://github.com/user-attachments/assets/5eeed97b-05ff-4a65-a9a8-072c8b0b7c15"
/>

Resolves #662
Resolves #663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request linter

2 participants

@domingo2000 @marcoroth