Skip to content

Dev Tools: Avoid overriding non-static position when attaching herb overlay #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoroth merged 1 commit into from
Dec 22, 2025
Merged

Dev Tools: Avoid overriding non-static position when attaching herb overlay #999

marcoroth merged 1 commit into from
Dec 22, 2025

Conversation

@kozy4324
Copy link
Contributor

@kozy4324 kozy4324 commented Dec 21, 2025

When showing the Herb overlay:

  • For non-static positions (absolute, fixed, sticky, relative), the existing position value should be respected.
  • Non-static elements already serve as the positioning context for absolutely positioned children, so overriding them is unnecessary.

Thank you.
marcoroth
marcoroth approved these changes Dec 22, 2025
View reviewed changes
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point, thank you @kozy4324! 🙏🏼
@marcoroth marcoroth merged commit eba2085 into marcoroth:main Dec 22, 2025
12 checks passed
@kozy4324 kozy4324 deleted the avoid-overriding-position branch December 26, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tools typescript

2 participants

@kozy4324 @marcoroth