improvement: cell styles on sort/pagination #7452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where cell styles and hover text were incorrectly applied during pagination when tables were sorted in descending order. Previously, the row ID calculation didn't account for the skip offset when descending, causing all pages to show styles for the same last N rows of the dataset instead of the correct rows for each page.
Key Changes:
- Fixed row ID calculation in
_style_cellsand_hover_cellsto account for pagination offset when sorting in descending order - Added
descendingparameter to_hover_cellsmethod signature for consistency with_style_cells - Removed obsolete documentation warning about styling misalignment during sorting
- Added comprehensive regression test covering multiple pages with descending sort
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marimo/_plugins/ui/_impl/table.py |
Fixed row ID calculation for descending sort pagination by subtracting skip offset; added descending parameter to _hover_cells; removed obsolete documentation warning |
tests/_plugins/ui/_impl/test_table.py |
Added regression test verifying cell styles work correctly across all pages when sorted descending with pagination enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Light2Dark
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup comment from #6223