Fix Ctrl+Click to select cell type on Windows/Linux
#7580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixes #7547 The desired behavior of the create cell button is to default to adding a Python cell on click, with `Ctrl+Click` (`Cmd+Click` on Mac) opening a dropdown to select other cell types. This worked on Mac but not on Windows/Linux because Radix's `DropdownMenuTrigger` ignores `Ctrl+Click` (likely because browsers historically use `Ctrl+Click` for "open link in new tab" and Radix avoids interfering with that). The fix bypasses Radix's trigger behavior entirely. We intercept pointer events in the capture phase before Radix sees them, stop propagation, and manage the dropdown's open state ourselves. Open to other ideas if folks have it. I've implemented the fix on my windows machine.
mscolnick
previously approved these changes
Dec 23, 2025
## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes #123). --> ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
akshayka
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7547
The desired behavior of the create cell button is to default to adding a Python cell on click, with
Ctrl+Click(Cmd+Clickon Mac) opening a dropdown to select other cell types. This worked on Mac but not on Windows/Linux because Radix'sDropdownMenuTriggerignoresCtrl+Click(likely because browsers historically useCtrl+Clickfor "open link in new tab" and Radix avoids interfering with that).The fix bypasses Radix's trigger behavior entirely. We intercept pointer events in the capture phase before Radix sees them, stop propagation, and manage the dropdown's open state ourselves. Open to other ideas if folks have it. I've implemented the fix on my windows machine.