fix: set only partial updates for config changes #7634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors config update operations to use partial updates instead of full config replacements, preventing unintended overwrites of backend config values that aren't managed by specific UI components.
Key Changes:
- Modified config-saving functions to accept and send
Partial<UserConfig>instead of full config objects - Updated all state setters to use functional updates that merge new values with previous state
- Implemented dirty field tracking in form-based config updates to only send changed values
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/core/config/feature-flag.tsx |
Added void keyword to mark fire-and-forget async call |
frontend/src/core/ai/config.ts |
Changed parameter types to Partial<UserConfig> and updated state setters to merge with previous state |
frontend/src/components/editor/package-alert.tsx |
Implemented dirty value tracking to only send changed fields and updated state setter |
frontend/src/components/editor/controls/keyboard-shortcuts.tsx |
Refactored to use partial configs and functional state updates |
frontend/src/components/editor/chrome/wrapper/footer-items/runtime-settings.tsx |
Simplified hook usage, fixed callback syntax, and updated state setters |
frontend/src/components/editor/actions/useConfigActions.tsx |
Updated to use partial config updates and functional state setters |
frontend/src/components/app-config/user-config-form.tsx |
Updated state setter to use functional update pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Light2Dark
approved these changes
Dec 30, 2025
Contributor
Light2Dark
left a comment
Light2Dark
left a comment
There was a problem hiding this comment.
should we apply the same treatment for saveAppConfig and setAppConfig
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.