feat: sandboxed home #7702
feat: sandboxed home #7702
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
Before releasing this feature, we should make sure the UX issues you alluded to in the PR description, in particular when the frontend handles the case in which sandbox notebooks fail to start (e.g., uv sync fails):
- the error should be communicated to the user;
- we should either fail fast (show the error and stop trying to connect to the kernel), or provide a way for the user to fix the error and try again (edit script metadata, then click a button to try creating the venv again)
If you prefer to work in multiple PRs, sandbox home could be feature flagged until the FE handles the failure case
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
Shutting down the server on the frontend should also shutdown running notebooks, but that does not appear to be happening right now
Co-authored-by: Akshay Agrawal <akshay@marimo.io>
for more information, see https://pre-commit.ci
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
Might not be related to this change, but I created a new notebook and marimo was not added to its script metadata:
# /// script
# requires-python = ">=3.13"
# dependencies = [
# "matplotlib==3.10.8",
# ]
# ///Additionally, I am finding a bad interaction with format on save, see video:
ruff-install.mp4
for more information, see https://pre-commit.ci
Co-authored-by: Akshay Agrawal <akshay@marimo.io>
for more information, see https://pre-commit.ci
|
marimo not being added a a bug particular to this (but we should fix). Opening the motebook again and it works as expected. For the ruff error, I'm just going to throw an error and revisit if we need to. Ruff is installed in the sandbox, but the wrong sandbox! Installation path goes through the kernel |
for more information, see https://pre-commit.ci
|
Sync'd with Akshay offline- gave his approval ! |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.3-dev8 |
dmadisetti
added
the
release-highlight
## 📝 Summary Introduces a page on `marimo edit ./directory" or the Home page. Additionally includes details on the "Sandboxed Home" feature included in #7702 After a bit of discussion we noted we had been using the term "Home" and "Sandboxed Home" internally, so this doc change is consistent with that terminology.
📝 Summary
Adds
--sandboxtomarimo edit --sandbox directory/. Leveraging pep-723 where ever it can.closes #2598 rebases and supercedes #7640
marimo edit --sandbox(home mode)UX changes on kernel launch failure: