-
Notifications
You must be signed in to change notification settings - Fork 892
Move marimo import to top in convert command #7828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
When converting Jupyter notebooks, the `import marimo as mo` statement was being added as the last cell. This caused issues when earlier cells used `mo.md()` or `mo.sql()` - they would fail because marimo wasn't imported yet. Now the import is added as the first cell instead. Fixes MO-4937
ebdd406 to
6a40619
Compare
|
@koaning you will need to run the tests locally and commit the updated snapshots |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
c436085 to
9c0180f
Compare
|
@akshayka ping, I think it's all fixed now. |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.5-dev32 |
This PR moves the `import marimo as mo` to the top cell when we convert from Jupyter to marimo. Having the cell at the bottom is bothersome because it may not run at all if the original notebook contains errors.
This PR moves the `import marimo as mo` to the top cell when we convert from Jupyter to marimo. Having the cell at the bottom is bothersome because it may not run at all if the original notebook contains errors.
This PR moves the
import marimo as moto the top cell when we convert from Jupyter to marimo. Having the cell at the bottom is bothersome because it may not run at all if the original notebook contains errors.