fix: normalize git urls in conversion from jupyter to marimo deps #7876
+138
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dmadisetti
reviewed
Jan 16, 2026
| """ | ||
| # Check if this looks like a git URL or VCS URL | ||
| # Common patterns: git+https://, git+ssh://, git+git://, https://github.com/... | ||
| is_git_url = package.startswith("git+") or ( |
Collaborator
There was a problem hiding this comment.
Opposed to hardcode I'd re.match(r"git\+.*/([^\.]+).git$")
Collaborator
There was a problem hiding this comment.
or urlparse(package.split("+")).pop() I don't think we should confine to github/ gitlab etc.
dmadisetti
approved these changes
Jan 19, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.5-dev20 |
botterYosuke
pushed a commit
to botterYosuke/marimo
that referenced
this pull request
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize git urls in conversion from jupyter to marimo deps