improvement: use vega 6 mimetype, capture screenshots on pdf export #7906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
commented
Jan 20, 2026
| "application/vnd.vega.v5+json", | ||
| "application/vnd.vegalite.v6+json", | ||
| "application/vnd.vega.v6+json", | ||
| ]); |
manzt
previously approved these changes
Jan 20, 2026
Contributor
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
LGTM. Are the vega specs kept in the repr mimebundle for the ipynb exports? I know that is separate from these changes, but some renders will support that directly on top of PNG.
Contributor
Author
|
@manzt yes, we augment the outputs with the PNG (instead of overwrite) |
Contributor
|
Great. |
Light2Dark
previously approved these changes
Jan 20, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.5-dev25 |
botterYosuke
pushed a commit
to botterYosuke/marimo
that referenced
this pull request
Jan 21, 2026
…arimo-team#7906) This makes sure we use the correct vega/vegalite mime type (now 6) and well as updates some logic to include also include vega charts when capturing screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure we use the correct vega/vegalite mime type (now 6) and well as updates some logic to include also include vega charts when capturing screenshots.