fix: enable search for index columns in PandasTableManager #7947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
mscolnick
reviewed
Jan 23, 2026
| searches columns, not the index. This override resets the index (if needed) | ||
| before searching, making index values searchable. | ||
| """ | ||
| # Check if we need to reset the index (same logic as to_json_str) |
Contributor
There was a problem hiding this comment.
we can probably pull out the logic in to_json_str to shared functions to share more of this code
mscolnick
reviewed
Jan 23, 2026
| data_for_search = data_for_search.reset_index() | ||
|
|
||
| # Create a temporary manager with reset index for searching | ||
| temp_manager = PandasTableManager(data_for_search) |
Contributor
There was a problem hiding this comment.
could we just return return PandasTableManager(data_for_search).search(query)
mscolnick
reviewed
Jan 23, 2026
| # Default index, use parent search method and convert result back to PandasTableManager | ||
| searched_manager = super().search(query) | ||
| searched_data = searched_manager.data.to_native() | ||
| return PandasTableManager(searched_data) |
Contributor
There was a problem hiding this comment.
i think return super().search(query) would be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #7945
This PR enables search functionality for index columns in the PandasTableManager.
🔍 Description of Changes
Currently, the table search logic only scans DataFrame columns. When users call df.value_counts(), the resulting labels are stored in the index, which made them unsearchable.
Changes:
Testing:
📋 Checklist