Skip to content

Backport PR #29827 on branch v3.10.x (TST: Remove unnecessary test images) #29867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 5, 2025

PR summary

Note that I only backported the first commit of #29827; I don't think it makes sense to make the API change of check_figures_equal defaults in a bug fix release.

PR checklist

@QuLogic QuLogic added this to the v3.10.2 milestone Apr 5, 2025
@dstansby
Copy link
Member

A rebase should fix the doc build, if this is something we still want to backport.

@dstansby dstansby force-pushed the auto-backport-of-pr-29827-on-v3.10.x branch from 2f88659 to 59a9774 Compare April 24, 2025 21:43
@dstansby
Copy link
Member

I've rebased on to the latest v3.10.x

@ksunden
Copy link
Member

ksunden commented May 2, 2025

Rerunning failed Azure Linux checks. They were all timeout errors, not image test errors, so probably unrelated to the changes here, but there were 9 failures, which is more than we usually see for stochastic failures. And it was on Linux where the vast majority of such timeout problems are on Windows for us.

I'll be satisfied if they pass, will re-evaluate if they fail.

@ksunden
Copy link
Member

ksunden commented May 2, 2025

Hmmm... seems like we are continuing to get failures on the Azure Linux 3.11 build...

However, does not appear to be unique to this PR upon closer look at recent backports, so willing to merge over.

@ksunden ksunden merged commit 0595366 into matplotlib:v3.10.x May 2, 2025
36 of 38 checks passed
@QuLogic QuLogic deleted the auto-backport-of-pr-29827-on-v3.10.x branch May 3, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants