Skip to content

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 24, 2023

Description

Add a new module landing page for CSS Properties and Values API.

other changes:

  • link to guides and module pages
  • Add BCD where possible
  • add more details to "CSS cascading variables"

Motivation

With the addition of @property, there's a need to differentiate between

@bsmth bsmth requested review from a team as code owners November 24, 2023 14:18
@bsmth bsmth requested review from dipikabh and wbamberg and removed request for a team November 24, 2023 14:18
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs labels Nov 24, 2023
Copy link
Contributor

github-actions bot commented Nov 24, 2023

Preview URLs (8 pages)
Flaws (2)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_cascading_variables
Title: CSS custom properties for cascading variables
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_syntax/Error_handling#invalid_custom_properties

URL: /en-US/docs/Web/CSS/CSS_properties_and_values_API
Title: CSS properties and values API
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_houdini
External URLs (1)

URL: /en-US/docs/Web/CSS/@property
Title: @property

(comment last updated: 2023-12-18 13:55:46)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot removed the Content:WebAPI Web API docs label Nov 27, 2023
@bsmth bsmth requested a review from estelle November 27, 2023 10:52
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 27, 2023
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bsmth ! Approving only for the Web/API changes, as @estelle is on the much more extensive CSS changes.

@bsmth bsmth requested a review from estelle November 27, 2023 18:58
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review (up thru css cascading values)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more feedback

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
bsmth and others added 4 commits December 15, 2023 17:14
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@bsmth bsmth requested a review from estelle December 15, 2023 17:23
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

several suugestions. all minor. we're close.

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@bsmth bsmth requested a review from estelle December 18, 2023 09:32
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!
Thanks! 🎉

@estelle estelle merged commit 948ade9 into mdn:main Dec 18, 2023
@bsmth bsmth deleted the css-module-custom-prop branch December 18, 2023 19:52
@bsmth
Copy link
Member Author

bsmth commented Dec 18, 2023

Super, thanks 🎉

@bsmth bsmth mentioned this pull request Dec 21, 2023
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
* docs(css): add module page for CSS Properties and Values API

* link to guides and module pages

* docs(css): remove unnecessary string identifier

* docs(css): fix flaws in module pages

* docs(css): check-in changes, remove unnecessary styles

* docs(css): changes following reviewer feedback, conform to existing doc conventions for module pages

* Apply suggestions from code review

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

* docs(css): changes following reviewer feedback, make hidden examples a single block

* docs(css): changes following reviewer feedback

* docs(css): changes following reviewer feedback

* Update files/en-us/web/css/css_cascading_variables/index.md

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

* docs(css): changes following reviewer feedback

* docs(css): changes following reviewer feedback

* Apply suggestions from code review

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

* Fix typos

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* docs(css): Move 'syntax strings' up into syntax DL

* docs(css): Improvements following reviewer feedback

* Update files/en-us/web/css/css_properties_and_values_api/index.md

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

* Apply suggestions from code review

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

* docs(css): Correct internal xrefs to use locale / root relative

* docs(css): Improvements following reviewer feedback

---------

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs

4 participants