-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Only use *.example and example.com as example domains #41428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Josh-Cena
wants to merge
1
commit into
mdn:main
Choose a base branch
from
Josh-Cena:example-domain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmth
reviewed
Oct 8, 2025
Access-Control-Request-Method: GET | ||
Access-Control-Request-Headers: content-type,x-requested-with | ||
Origin: https://foo.bar.org | ||
Origin: https://example.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to keep a subdomain here and the one below?
Suggested change
Origin: https://example.com | |
Origin: https://subdomain.example.com |
rebloor
reviewed
Oct 8, 2025
Comment on lines
+42
to
+43
1. You visit `a-shopping-site.example`, which uses `ad-tracker.example` to deliver its adverts on the web. `ad-tracker.example` sets a cookie associated with the `ad-tracker.example` domain. While you are on `a-shopping-site.example`, `ad-tracker.example` receives information about the products you browse. | ||
2. You now visit `a-news-site.example` that uses `ad-tracker.example` to deliver adverts. `ad-tracker.example` read its cookie and use the information collected from `a-shopping-site.example` to decide which adverts to display to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotproto any thoughts on this? Does it make the examples to unrealistic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:CSS
Cascading Style Sheets docs
Content:Glossary
Glossary entries
Content:HTTP
HTTP docs
Content:JS
JavaScript docs
Content:Learn
Learning area docs
Content:PWA
Progressive Web Apps content
Content:Security
Security docs
Content:WebAPI
Web API docs
Content:WebExt
WebExtensions docs
size/m
[PR only] 51-500 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a lot of example domains that may happen to be valid, fixing #39865. It is impossible to find all such examples, but I found a good bunch.