Skip to content

Editorial review: Add docs for restrictOwnAudio constraint #41437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Editorial review: Add docs for restrictOwnAudio constraint #41437

wants to merge 5 commits into from
+214 −23

Conversation

chrisdavidmills
Copy link
Contributor

Description

Chrome 141 adds support for the restrictOwnAudio captured display surface constrainable property. See https://chromestatus.com/feature/5128140732760064.

This PR adds docs for this feature

Motivation

Additional details

Related issues and pull requests
@chrisdavidmills chrisdavidmills requested a review from a team as a code owner October 8, 2025 12:19
@chrisdavidmills chrisdavidmills requested review from wbamberg and removed request for a team October 8, 2025 12:19
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 8, 2025
@chrisdavidmills chrisdavidmills changed the title Add docs for restrictOwnAudio constraint Oct 8, 2025
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025 •
edited
Loading

Preview URLs (6 pages)
Flaws (4)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/MediaTrackSettings
Title: MediaTrackSettings
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/MediaTrackSettings/resizeMode
    • Can't resolve /en-US/docs/Web/API/MediaTrackConstraints/resizeMode

URL: /en-US/docs/Web/API/MediaTrackSupportedConstraints
Title: MediaTrackSupportedConstraints
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/MediaTrackConstraints/resizeMode
  • macros:
    • Can't resolve /en-US/docs/Web/API/MediaTrackSupportedConstraints/resizeMode

(comment last updated: 2025-10-09 08:59:52)
beaufortfrancois
beaufortfrancois reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits
files/en-us/web/api/mediatrackconstraints/restrictownaudio/index.md Outdated
> [!NOTE]
> If the captured display surface doesn't include system audio, this setting will have no effect.

If the value is given as `ideal`, that field's boolean value indicates an ideal setting for the `restrictOwnAudio` feature; if it can't be met, then the request will result in an error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you meant exact, not ideal right? See https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints#constrainboolean
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point. I've updated it to exact, and altered the description to suit.
chrisdavidmills and others added 3 commits October 8, 2025 18:54
@chrisdavidmills
Copy link
Contributor Author

Thanks for the review, @beaufortfrancois! I'll move this on to the editorial review stage now, but let me know if you think anything needs further attention.
@chrisdavidmills chrisdavidmills changed the title Technical review: Add docs for restrictOwnAudio constraint Oct 9, 2025
@dipikabh dipikabh requested review from dipikabh and removed request for wbamberg October 9, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed

2 participants

@chrisdavidmills @beaufortfrancois