DocParser.parseFromString() - update for trusted types #41490
Merged
+113
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Preview URLs External URLs (1)URL:
(comment last updated: 2025-10-13 23:42:36) |
hamishwillee
commented
Oct 13, 2025
hamishwillee
commented
Oct 13, 2025
Comment on lines
+51
to
+52
| > The browser may actually return an {{domxref("HTMLDocument")}} or {{domxref("XMLDocument")}} object. | ||
| > These derive from {{domxref("Document")}} and add no attributes: they are essentially equivalent. |
There was a problem hiding this comment.
FYI it will return one of these object on all the major browsers. So all the browsers are not spec compliant, but it doesn't matter since they don't add any methods. They aren't a useful abstraction for end users, who should just check the contentType property for any useful information.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
32 tasks
sideshowbarker
approved these changes
Oct 13, 2025
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
|
@sideshowbarker Thanks for the review - all suggestions accepted. It looks like I was pretty sloppy sorry. |
hamishwillee
commented
Oct 13, 2025
hamishwillee
commented
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the TrustedType documentation for
DocParser.parseFromString()so that it includes boilerplate and security considerations.Quite a lot of additional info too.
Project tracking in #37518