Skip to content

Add README to project. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 14, 2023
Merged

Add README to project. #1

merged 8 commits into from
Sep 14, 2023

Conversation

jalcine
Copy link
Member

@jalcine jalcine commented Dec 13, 2022 •
edited by aimee-gm
Loading

Adds setup instructions for the project.

Fixes #8
tantek
tantek approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested the setup instructions, but the rest looks good to me. Would be good to get someone familiar with node to try them out and verify they work.
aciccarello
aciccarello reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@aciccarello aciccarello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be great to have this in the repo. Might benefit from a few adjustments.

Regarding the question if the steps work, I was able to get things running with the corresponding npm install & npm start commands.
@gRegorLove gRegorLove mentioned this pull request Sep 14, 2023
Closed
@aimee-gm @aciccarello
Update README.md
df482ab 
Co-authored-by: Anthony Ciccarello <aciccarello@users.noreply.github.com>
aimee-gm
aimee-gm reviewed Sep 14, 2023
View reviewed changes
README.md Outdated
You can view your running local application at this URL:

```
http://localhost:9080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs on port 9000, not 9080
@aimee-gm aimee-gm merged commit 6be8e51 into next Sep 14, 2023
@aimee-gm aimee-gm deleted the add-readme branch September 14, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@jalcine @tantek @aciccarello @aimee-gm