Swap querystring for body-parser #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zegnat
force-pushed
the
bugfix/have-express-parse-form-submission
branch
from
ce1f123 to
08d4e39
Compare
Zegnat
force-pushed
the
bugfix/have-express-parse-form-submission
branch
from
08d4e39 to
be961ff
Compare
|
Updated this to be a clean merge again after the swap to a different microformats parser. Also found out that Express actually bundles a form parser, so I dropped the need for an external dependency completely. |
aimee-gm
approved these changes
Sep 14, 2023
|
@gRegorLove just tested this and looks to be working 👍 It should be good to merge |
|
Somehow missed your comment, @gRegorLove! Apologies! This has been ready to merge IMO. But thanks for confirming it works @aimee-gm! (I do not have write access on this repo, else I would have opted to merge it myself.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.
This aligns us more with Express’ own documentation by using their bundled middleware to parse the form.